[PM-12729] Add QA flag to circumvent minimum client version to retreive ssh key ciphers #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quexten
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5005 +/- ##
=======================================
Coverage 43.06% 43.06%
=======================================
Files 1412 1412
Lines 64775 64775
Branches 5920 5920
=======================================
Hits 27894 27894
Misses 35649 35649
Partials 1232 1232 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
New Issues
Fixed Issues
|
LaunchDarkly flag references🔍 1 flag added or modified
|
gbubemismith
approved these changes
Nov 20, 2024
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
Co-authored-by: Matt Bishop <[email protected]> Co-authored-by: aj-bw <[email protected]>
vgrassia
pushed a commit
to vgrassia/server
that referenced
this pull request
Nov 21, 2024
Co-authored-by: Matt Bishop <[email protected]> Co-authored-by: aj-bw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12729
📔 Objective
Add a feature flag (server side only) to override the ssh key cipher version check for QA testing, since QA clients are on 2024.11.x but we only want 2024.12.x and onward to receive these ciphers in production.
This will only be enabled on dev/qa instances, never prod, and removed in ~2 releases
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes